Fixed native_type generating wrong C++ code.#8003
Closed
thomz12 wants to merge 2 commits intogoogle:masterfrom
Closed
Fixed native_type generating wrong C++ code.#8003thomz12 wants to merge 2 commits intogoogle:masterfrom
thomz12 wants to merge 2 commits intogoogle:masterfrom
Conversation
native_type generated C++ code that couldn't be compiled when used without native_inline.
Removed use of make_unique. I had to get rid of some define that defined 'new' to 'DEBUG_NEW' in one test. I think this might not be in use anymore?
Contributor
|
This pull request is stale because it has been open 3 weeks with no activity. Please comment or label |
Contributor
|
This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period. |
Contributor
|
Bump, this is still an issue and this PR should get merged. |
|
Agree, also having this issue. @thomz12 could you re-open the PR and try to get some visibility and reviewers on it? Cheers! |
Contributor
|
Yes, indeed. |
Collaborator
|
Please reopen a PR with this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native_type generated C++ code that couldn't be compiled when used without native_inline.
Related to issue #6770, which never got fixed.
Before, a schema like this would generate code that couldn't be compiled:
Using the
Vector3Das an array or with the "native_inline" attribute did work as expected.I've added some code to the C++ generator to fix the issue so it works by itself. It has to create a
unique_ptrcorrectly when unpacking and de-referencing one when packing.I also added some test cases for the
native_type, one with thenative_inlineattribute and one without toNativeTypeTest.