Add absolute file names option to BFBS#8055
Merged
dbaileychess merged 4 commits intogoogle:masterfrom Nov 19, 2023
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dbaileychess
approved these changes
Nov 19, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Add absolute file names option (#1) * Use ternary style for if --------- Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Add absolute file names option (#1) * Use ternary style for if --------- Co-authored-by: Derek Bailey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add new command line switch to expose absolute BFBS paths instead of relative. This makes it easier for downstream tools to reason about the set of input files rather than trying to interpret relative paths. (#8053 )
Why
Paths on Windows today can be broken since they omit the drive letter:
//../../../:/git/myfile.fbsI've tested locally and seems to work the way I expect on both Windows and Linux (WSL). I don't have access to a MacOS machine to test with. If you can suggest good test cases for this, I'm happy to write them, though C++ is not a language I work in regularly, so I might need some help there.
Thanks!