Add argument to FlatBufferToString for quotes around field names#8090
Merged
dbaileychess merged 2 commits intogoogle:masterfrom Nov 18, 2023
Merged
Add argument to FlatBufferToString for quotes around field names#8090dbaileychess merged 2 commits intogoogle:masterfrom
dbaileychess merged 2 commits intogoogle:masterfrom
Conversation
dbaileychess
approved these changes
Nov 18, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…ault false (google#8090) Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…ault false (google#8090) Co-authored-by: Derek Bailey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
FlatBufferToStringhas no argument to set quotes around field names. But many JSON parsers require quotes around field names. AlsoToStringVisitorclass have an argument to put quotes around field name, but it is not used.I added argument quotes to function
FlatBufferToStringwith default value false, which was used before changes. I added this argument as the last argument, so it supports backwards compatibility.