Add const qualifier to non-mutated FlatbufferBuilder parameter#8101
Merged
le-michael merged 3 commits intogoogle:masterfrom Sep 30, 2023
Lukasdoe:master
Merged
Add const qualifier to non-mutated FlatbufferBuilder parameter#8101le-michael merged 3 commits intogoogle:masterfrom Lukasdoe:master
le-michael merged 3 commits intogoogle:masterfrom
Lukasdoe:master
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
There are comments to prevent clang-format on those lines. Can you try reverting the clang format related changes? |
Contributor
Author
|
Yes, sorry, I don't know why CLion ignored the I'm currently still waiting to be added to my company's CLA list... |
le-michael
approved these changes
Sep 30, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…e#8101) Co-authored-by: Michael Le <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…e#8101) Co-authored-by: Michael Le <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #8100 .
Only code change is in line 1474, all other changes are clang-format