[Swift] Migrating benchmarks to a newer lib.#8168
Merged
dbaileychess merged 7 commits intogoogle:masterfrom Nov 23, 2023
Merged
[Swift] Migrating benchmarks to a newer lib.#8168dbaileychess merged 7 commits intogoogle:masterfrom
dbaileychess merged 7 commits intogoogle:masterfrom
Conversation
Collaborator
mustiikhalil
commented
Nov 20, 2023
mustiikhalil
commented
- The following PR adds a similar push to byte buffer for native structs that was introduced in [Swift] Push contiguous bytes #8157.
- Migrates our benchmarks.
- General code formatting.
Collaborator
Author
|
@hassila I migrated the benchmark library to use the one you suggested. |
mustiikhalil
force-pushed
the
update-struct-pushing-to-buffer
branch
from
0557bdb to
9609ff5
Compare
Contributor
|
Cool! I'm a bit biased having been involved in that package, so obviously ageee. There are a few tweaks needed, I'll try to review tomorrow. |
hassila
reviewed
Nov 20, 2023
Contributor
hassila
left a comment
hassila
left a comment
There was a problem hiding this comment.
First comment - will review more...
tests/swift/benchmarks/Benchmarks/FlatbuffersBenchmarks/FlatbuffersBenchmarks.swift
Outdated
Show resolved
Hide resolved
Contributor
|
Some suggestions here: |
hassila
reviewed
Nov 21, 2023
tests/swift/benchmarks/Benchmarks/FlatbuffersBenchmarks/FlatbuffersBenchmarks.swift
Show resolved
Hide resolved
Updates benchmarks & cleanup Adds native struct vector tests
mustiikhalil
force-pushed
the
update-struct-pushing-to-buffer
branch
from
43f21b3 to
6f56762
Compare
Collaborator
Author
|
@dbaileychess this is ready for review |
dbaileychess
approved these changes
Nov 23, 2023
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Adds Nativestructs pointer push into ByteBuffer Updates benchmarks & cleanup Adds native struct vector tests * Address PR comments * Add more benchmarks * Some benchmark cleanup * Return back to 1M structs * Tweak Structs benchmark * Moves swift Benchmarks folder from /tests to /benchmarks --------- Co-authored-by: Joakim Hassila <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Adds Nativestructs pointer push into ByteBuffer Updates benchmarks & cleanup Adds native struct vector tests * Address PR comments * Add more benchmarks * Some benchmark cleanup * Return back to 1M structs * Tweak Structs benchmark * Moves swift Benchmarks folder from /tests to /benchmarks --------- Co-authored-by: Joakim Hassila <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.