Fix cmake build for old versions#8173
Merged
dbaileychess merged 2 commits intogoogle:masterfrom Nov 23, 2023
Merged
Conversation
Adresses all these issues -> google#7994 google#7979 google#8049 Fix 7994, Fix 7979, Fix 8049
Collaborator
|
I needed |
dbaileychess
approved these changes
Nov 23, 2023
Contributor
Author
|
fair enough and at some point it probably makes sense to change the minimal required cmake version to 3.20.0 then this check can be removed again |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Adresses all these issues -> google#7994 google#7979 google#8049 Fix 7994, Fix 7979, Fix 8049 Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
Adresses all these issues -> google#7994 google#7979 google#8049 Fix 7994, Fix 7979, Fix 8049 Co-authored-by: Derek Bailey <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses all these issues ->
#7994
#7979
#8049
Fix 7994, Fix 7979, Fix 8049
I wasn't to sure what the deal with MSVC is here even after looking into this commit 561a936
@dbaileychess maybe we should never use
INTERFACEfor flatsample?