Add a unit test for odd-sized small structs (for #8117)#8363
Merged
dbaileychess merged 4 commits intogoogle:masterfrom Aug 20, 2024
Merged
Add a unit test for odd-sized small structs (for #8117)#8363dbaileychess merged 4 commits intogoogle:masterfrom
dbaileychess merged 4 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dbaileychess
approved these changes
Aug 20, 2024
|
Thanks again @nolen777 for your diligence. |
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…#8363) * add an odd sized test * formatting --------- Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
…#8363) * add an odd sized test * formatting --------- Co-authored-by: Derek Bailey <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test with an odd-sized struct to alignment_test, to protect against recurrence of #8117
I verified that this new test passes. I also tried merging this change on top of 72aa85a, where the bug in 8117 first appeared; the test fails there with the expected bug (zero values present at the beginning of the vector).
Closes #8117