[Swift] Improves vectors performance & arrays within lib#8415
Merged
mustiikhalil merged 2 commits intogoogle:masterfrom Nov 19, 2024
Merged
[Swift] Improves vectors performance & arrays within lib#8415mustiikhalil merged 2 commits intogoogle:masterfrom
mustiikhalil merged 2 commits intogoogle:masterfrom
Conversation
Collaborator
Author
|
Master: Current: |
mustiikhalil
changed the title
mustiikhalil
force-pushed
the
mmk/improve-array-performance
branch
from
de74d7a to
35d4cab
Compare
Collaborator
Author
|
Master: Current: |
mustiikhalil
force-pushed
the
mmk/improve-array-performance
branch
2 times, most recently
from
f643dc7 to
c7d5edf
Compare
Collaborator
Author
|
@hassila I upgraded the package for benchmarks however it seems that the benchmarks changes a lot for example:
1.27.2 1.12.0 |
Contributor
|
Yes, the default output format changed to be scaled per inner loop iteration - those are denoted by |
Collaborator
Author
|
Oh perfect! thanks for the clarification! |
Contributor
|
That was done here: https://github.com/ordo-one/package-benchmark/releases/tag/1.14.0 If you want the old output for the benchmark as a whole, rather than scaled to per iteration, you can add |
…ts in swift Improves performance for all arrays and for loops Uses a tuple instead of allocating a struct each time we start iterating over fieldloc Updates benchmark library
mustiikhalil
force-pushed
the
mmk/improve-array-performance
branch
from
c7d5edf to
9809e0f
Compare
mustiikhalil
force-pushed
the
mmk/improve-array-performance
branch
2 times, most recently
from
be9b7c2 to
8147231
Compare
mustiikhalil
force-pushed
the
mmk/improve-array-performance
branch
from
4d2485d to
b9c5669
Compare
aardappel
approved these changes
Nov 19, 2024
razvanalex
pushed a commit
to razvanalex/flatbuffers
that referenced
this pull request
Dec 3, 2024
* Improves vectors performance and adds a benchmark to vectors of offsets in swift Improves performance for all arrays and for loops Uses a tuple instead of allocating a struct each time we start iterating over fieldloc Updates benchmark library * Fixing swift Wasm ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR improves the performance of usage of arrays, and for loops within the swift language. Instead of using the sugar syntax of a for loop in swift, example
we use stride to have a better control over the iteration and speed of the code: