Merged
Conversation
mering
force-pushed
the
fix-bazel-reflection-path
branch
from
52027c5 to
91982d2
Compare
mering
force-pushed
the
fix-bazel-reflection-path
branch
2 times, most recently
from
50ef412 to
2c21a81
Compare
mering
force-pushed
the
fix-bazel-reflection-path
branch
3 times, most recently
from
277777b to
7f216cd
Compare
Merged
mering
force-pushed
the
fix-bazel-reflection-path
branch
7 times, most recently
from
8a7ae42 to
8c4bfae
Compare
mering
force-pushed
the
fix-bazel-reflection-path
branch
2 times, most recently
from
4a5f612 to
a5f3974
Compare
mering
commented
Jan 23, 2025
mering
force-pushed
the
fix-bazel-reflection-path
branch
from
a5f3974 to
b3ec2fd
Compare
We need to copy the .fbs files into the package used for .bfbs files. This is necessary as flatc doesn't provide support to specify the full output file name for an .fbs file in a different folder. I tried OUTPUT_FILE env var but this doesn't seem to be honored by flatc.
mering
force-pushed
the
fix-bazel-reflection-path
branch
from
b3ec2fd to
eb5cd8b
Compare
dbaileychess
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error: