Closed
Conversation
maxburke
force-pushed
the
java-naming-fixes
branch
from
049e485 to
9baca1e
Compare
Collaborator
|
Thanks! If these were 4 PRs, that would make them so much easier to review. |
Contributor
Author
Should I split this into 4? The changes themselves to codegen are pretty small, which is why I lumped them together. |
…s a type named Vector [java] bugfix: fields named `notify` clash with Java built-in notify method [java] bugfix: fix clash between flatbuffer library Table type and schema types named Table [java] bugfix: uint enums need to emit values as long constants
nevi-me
force-pushed
the
java-naming-fixes
branch
from
9baca1e to
a4c0d0b
Compare
Collaborator
|
@maxburke is this obsolete at this point? |
Contributor
Author
|
Yup; closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java code generation bug fixes:
notifyclash with Java built-in notify method