[Python] Avoid include own type#8625
Merged
aardappel merged 1 commit intogoogle:masterfrom Jul 15, 2025
Merged
Conversation
github-actions
bot
added
c++
codegen
fliiiix
force-pushed
the
bugfix/double-include-own-type
branch
from
3725316 to
cce6539
Compare
fliiiix
force-pushed
the
bugfix/double-include-own-type
branch
from
cce6539 to
07788af
Compare
Contributor
Author
|
@akb825 any opinions on this change? |
Contributor
|
Looks good to me. |
Contributor
Author
|
@aardappel or @dbaileychess can this be merged? |
aardappel
reviewed
Jul 14, 2025
fliiiix
force-pushed
the
bugfix/double-include-own-type
branch
from
07788af to
11efd6b
Compare
This prevents the include of the type defined in the pyi, otherwise this leads to error message like this: error: Name XYZ already defined (possibly by an import) [no-redef]
fliiiix
force-pushed
the
bugfix/double-include-own-type
branch
from
11efd6b to
62e4da6
Compare
aardappel
approved these changes
Jul 15, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the include of the type defined in the pyi, otherwise this leads to error message like this:
error: Name XYZ already defined (possibly by an import) [no-redef]