Bugfix __eq__ for numpy data types#8646
Merged
aardappel merged 6 commits intogoogle:masterfrom Jul 26, 2025
Merged
Conversation
github-actions
bot
added
c++
codegen
fliiiix
force-pushed
the
bugfix/7890/comparison-numpy
branch
from
4e568e0 to
9d3b741
Compare
fliiiix
force-pushed
the
bugfix/7890/comparison-numpy
branch
from
9d3b741 to
4614299
Compare
Contributor
Author
|
@aardappel opinion on this? This addresses some long standing issues with NumPy in the Python code |
Collaborator
|
Looks good.. please next time don't include lots of formatting changes, that makes it harder to review (those can be in a separate PR). |
aardappel
approved these changes
Jul 26, 2025
Contributor
Author
|
fair enough 👍 i put the format changes in an extra commit but i forgot that GitHub unlike GitLab doesn't have a good viewer where you can check commit by commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__eq__correctly if type is np.array fix [Python][v23.1.21] Comparison operators of lists are broken if NumPy is available #7890