[C#] Added ToSizedArrayPadded(int padLeft, int padRight) to ByteBuffers to avoid unnecessary copying.#8658
Merged
aardappel merged 6 commits intogoogle:masterfrom Sep 9, 2025
Merged
Conversation
…os, len, padLeft, padRight) to the byteBuffers. This is for API completion and to avoid unnecessary copy when framing my packets. I needed this to create a flat buffer with space in front of it for header / metadata.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
petersvp
changed the title
Collaborator
|
@aardappel consider merge |
bjornharrtell
approved these changes
Sep 9, 2025
aardappel
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added 2 new functions to C#'s ByteBuffers:
public byte[] ToSizedArrayPadded(int padLeft, int padRight)public T[] ToArrayPadded<T>(int pos, int len, int padLeft, int padRight)I needed those to create byte buffers with room in front of them where i can hotwire a header containing the type info and/on package length for TCP Framing.
Code that calls .ToSizedArray only to create new byte array and yet another copy to add some padding wasn't the best approach, so I decided to add the padding feature in the library itself. This is great for highly optimized networking.
My old framing code was the bottleneck because of Buffer.BlockCopy that is after a Buffer.BlockCopy during the .ToSizedArray()
Consider adding something similar to other languages thay may need padding during their framing / similar use cases, where ToSizedArray is THE thing that creates the initial byte array.