gRPC callbackService support added#8666
Merged
aardappel merged 5 commits intogoogle:masterfrom Aug 28, 2025
Merged
Conversation
Contributor
Author
|
@dbaileychess @mustiikhalil @aardappel could you guys please review this , if there are any changes required , I'd be happy to make them |
aardappel
reviewed
Aug 10, 2025
Collaborator
aardappel
left a comment
There was a problem hiding this comment.
Generally looks good!
08398d8 to
7aa060d
Compare
aardappel
previously approved these changes
Aug 11, 2025
1f9f63e to
37c3981
Compare
Signed-off-by: shankeleven <[email protected]>
37c3981 to
c0232ab
Compare
Contributor
Author
|
there were some issues wiht the CI buildkite, so had to make some minor changes, nothing substantial |
aardappel
previously approved these changes
Aug 18, 2025
Collaborator
|
Some of the CI errors definitely relates to this PR: https://github.com/google/flatbuffers/actions/runs/17030064051/job/48271145482?pr=8666 |
…ervice & async_ reactor APIs); update formatting and method placement
aardappel
approved these changes
Aug 23, 2025
Contributor
Author
|
this buildkite check has not been triggered ig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Support for gRPC CallbackService
gRPC supports two flavors of asynchronous callbacks -- from their documentation:
https://grpc.io/docs/languages/cpp/callback/
Checklist