Skip to content

Add bounds checking to a C# method where it was missing#8673

Merged
aardappel merged 3 commits intogoogle:masterfrom
CurtHagenlocher:GH-8672
Aug 28, 2025
Merged

Add bounds checking to a C# method where it was missing#8673
aardappel merged 3 commits intogoogle:masterfrom
CurtHagenlocher:GH-8672

Conversation

@CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Aug 14, 2025

Adds bounds checking to an implementation of ByteBuffer.GetStringUTF8 where it was missing when the build-time variable BYTEBUFFER_NO_BOUNDS_CHECK isn't set.

Closes #8672.

@github-actions github-actions bot added the c# label Aug 14, 2025
Copy link
Collaborator

@bjornharrtell bjornharrtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjornharrtell
Copy link
Collaborator

@aardappel consider merge

@aardappel aardappel merged commit a6b337f into google:master Aug 28, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C# implementation of ByteBuffer.GetStringUTF8 doesn't have bounds check

3 participants