Swap the dependency of CreateX and X::Pack object API functions.#8754
Swap the dependency of CreateX and X::Pack object API functions.#8754aardappel merged 1 commit intogoogle:masterfrom
Conversation
|
Thanks, this seems like a sensible thing to swap. Likely the reason it was the other way around was historical, whichever came first. The CI error thinks you haven't checked in all the modified generated code, though for some reason only on Windows, even though it runs the same |
Previously: X::Pack forwarded to CreateX. Now: CreateX will forward to X::Pack. This is a step toward enabling using native types for tables when using the object API. When defining a native table, the user will be able to define a custom X::Pack method (which is more consistent with the existing native_type functionality for structs). By reversing the order of the dependencies, CreateX can continue to be auto-generated and will use the custom X::Pack method when overriden for native_type tables.
cosmith-nvidia
force-pushed
the
create-pack
branch
from
f48b614 to
c3e1ee1
Compare
@aardappel thanks! I manually copied the missing files over from the build/ directory. PTAL. |
|
Ok, LGTM, thanks! |
|
@aardappel fyi if we still target c++11 as lowest standard supported i think some test code here needs to be changed |
3 participants
Previously: X::Pack forwarded to CreateX.
Now: CreateX will forward to X::Pack.
This is a step toward enabling using native types for tables when using the object API. When defining a native table, the user will be able to define a custom X::Pack method (which is more consistent with the existing native_type functionality for structs). By reversing the order of the dependencies, CreateX can continue to be auto-generated and will use the custom X::Pack method when overriden for native_type tables.