Conversation
jtdavis777
left a comment
There was a problem hiding this comment.
@aardappel thanks for the thorough review! I can go back and not be so heavy handed with my cleanup.
Most of the file manager code that I cleaned up was brought in #7821, which was never used in our repo. I respect the callout that other people ingesting our code base may take advantage of them though.
|
Ok, I'd agree any code that comes from an incomplete/non-functional PR that was merged is probably good to delete if not used in your fix. Still would prefer to minimize renames. |
|
seems like a decent middle ground. I'll compare with the original and roll back to being less aggressive, and will put back the helper functions. |
|
looks like the way the fuzzer builds needs updating |
|
@jtdavis777 some docs for this feature would be nice |

Fixes #8784
Adds (my best attempt at) a minimally invasive implementation of
--file-names-only.Note that this version prints every file the program attempts to write -- during testing I found #8787 where python tries and silently fails to make a file. Other languages may have the same problem.