Updated bundle ID for FlutterEmbedder.framework#235
Updated bundle ID for FlutterEmbedder.framework#235stuartmorgan-g merged 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
While we normally don't worry about backwards compatibility, this is such a minor thing that I'd prefer not to break version compat just for it. We can add temporary code to try loading using the old bundle ID if this fails, with a TODO to remove it after the next version incompatibility.
(I'll add that to the patch tomorrow, unless you want to do it before then, since the engine change had landed and breaks using Flutter head on Mac)
|
added support for loading with the old ID if loading with the new ID fails. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Perfect, thanks!
Fix: #234
Update the bundle ID for FlutterEmbedder.framework to match the change at flutter/engine#7503