This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Simplify the API for launching Flutter#236
Merged
stuartmorgan-g merged 2 commits intogoogle:masterfrom Jan 17, 2019
Merged
Conversation
- Eliminate the distinction between source mode and snapshot mode; source mode hasn't worked since the switch to Dart2, and the relevant engine arguments are deprecated in flutter/engine#7497 - Hide the need for the first argument to be the executable from clients of the library; this is an implementation detail of the engine API, and not something that each client application should need to handle given that the expected use case is to provide a constructed argument array, rather than pass through argc/argv directly. (As part of this change, removes the macOS code to strip Xcode-added arguments, for the same reason.) This is a breaking change; clients will need to update the call to the primary entry point, including removing the dummy first argument they were likely providing in the arguments array.
franciscojma86
approved these changes
Jan 16, 2019
Contributor
|
LGTM with with two typo comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source mode hasn't worked since the switch to Dart2, and the relevant
engine arguments are deprecated in
Deprecate FlutterProjectArgs.main_path, packages_path flutter/engine#7497
of the library; this is an implementation detail of the engine API,
and not something that each client application should need to handle
given that the expected use case is to provide a constructed argument
array, rather than pass through argc/argv directly.
(As part of this change, removes the macOS code to strip Xcode-added
arguments, for the same reason.)
This is a breaking change; clients will need to update the call to the
primary entry point, including removing the dummy first argument they
were likely providing in the arguments array.