This repository was archived by the owner on Dec 3, 2025. It is now read-only.
add support for shift, option (alt), control and command (meta) modifier keys#239
Merged
stuartmorgan-g merged 2 commits intogoogle:masterfrom Jan 21, 2019
Merged
add support for shift, option (alt), control and command (meta) modifier keys#239stuartmorgan-g merged 2 commits intogoogle:masterfrom
stuartmorgan-g merged 2 commits intogoogle:masterfrom
Conversation
stuartmorgan-g
suggested changes
Jan 20, 2019
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just one nit, otherwise looks good.
stuartmorgan-g
approved these changes
Jan 21, 2019
Contributor
|
Why are we using Android-defined constants here? Shouldn't we use a platform-independent description of the modifier key state? |
Collaborator
There isn't one, so currently desktop on all platform is sending Android. See line 382 in this file, for instance. |
Contributor
|
I see, thanks for the clarification. I think we'll want to make one ourselves then, at some point. |
Collaborator
|
Yes, the current system of using system channels and internal implementation details should be replaced with a real embedding API (essentially #47, but for key events rather than text input). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes through the
NSEventModifierFlagvalues for shift, option, control and command as AndroidmetaStateflags.