Conversation
|
@jba FYI |
sandeepvinayak
force-pushed
the
spal-atomic-writes-gcp-memstore
branch
from
2a9a605 to
0ab460e
Compare
|
@jba just a friendly reminder if you can take a look at this PR. I have also added mongo implementation as well, enabled al the conformance tests. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Please address failing checks. |
|
@jba it should be good now. thanks! |
sandeepvinayak
force-pushed
the
spal-atomic-writes-gcp-memstore
branch
from
3d7ba74 to
42f717d
Compare
|
@jba runchecks on local are good except some kafka failures due to connection issues which is unrelated to this PR. Can you please retrigger the workflow for me? Or maybe you can give me a permission to trigger the workflow ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3523 +/- ##
==========================================
+ Coverage 73.26% 73.29% +0.03%
==========================================
Files 113 113
Lines 15079 15190 +111
==========================================
+ Hits 11048 11134 +86
- Misses 3265 3277 +12
- Partials 766 779 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The CI seems to be good now, please help to merge when you get chance, thank you! |
|
@jba just a reminder to merge if this is good to go, thanks! |
2 participants
Please use a title starting with the name of the affected package, or "all",
followed by a colon, followed by a short summary of the issue. Example:
blob/gcsblob: fix typo in documentation.Please reference any Issue related to this Pull Request. Example:
Fixes #1.See
here
for tips on good Pull Request description.