docstore/memdocstore: add support for atomic writes#3606
Merged
vangent merged 1 commit intogoogle:masterfrom Jul 26, 2025
Merged
docstore/memdocstore: add support for atomic writes#3606vangent merged 1 commit intogoogle:masterfrom
vangent merged 1 commit intogoogle:masterfrom
Conversation
vangent
changed the title
jba
requested changes
Jul 26, 2025
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
Looks good. Some minor fixes.
Contributor
|
I'll make the requested changes in a follow-on PR so I can merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more details: #3501
Please use a title starting with the name of the affected package, or "all",
followed by a colon, followed by a short summary of the issue. Example:
blob/gcsblob: fix typo in documentation.Please reference any Issue related to this Pull Request. Example:
Fixes #1.See
here
for tips on good Pull Request description.