mysql/gcpmysql: pass DialFunc directly to MySQL config#3632
Merged
vangent merged 2 commits intogoogle:masterfrom Nov 1, 2025
Merged
mysql/gcpmysql: pass DialFunc directly to MySQL config#3632vangent merged 2 commits intogoogle:masterfrom
vangent merged 2 commits intogoogle:masterfrom
Conversation
giautm
changed the title
giautm
changed the title
vangent
reviewed
Oct 30, 2025
giautm
force-pushed
the
g/gcpmysql-dialer
branch
3 times, most recently
from
0465388 to
663900b
Compare
giautm
force-pushed
the
g/gcpmysql-dialer
branch
from
663900b to
cb5e273
Compare
Contributor
Author
|
Let me update TF and verify the change before merge. |
giautm
force-pushed
the
g/gcpmysql-dialer
branch
from
4bce034 to
9ea2129
Compare
Contributor
Author
Verified. |
giautm
force-pushed
the
g/gcpmysql-dialer
branch
from
9ea2129 to
13872f0
Compare
Contributor
|
Why do you think this change is making it better? It's not obviously simpler to me |
Contributor
Author
It removed the call to two sync/atomics for locking in two places. One in this package and another in the MySQL driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3630
See how the driver handle
DialFunc: https://github.com/go-sql-driver/mysql/blob/76c00e35a8d48f8f70f0e7dffe584692bd3fa612/connector.go#L98-L110