blob/gcsblob: derive universe domain from credentials#3652
Merged
vangent merged 1 commit intogoogle:masterfrom Feb 9, 2026
Merged
blob/gcsblob: derive universe domain from credentials#3652vangent merged 1 commit intogoogle:masterfrom
vangent merged 1 commit intogoogle:masterfrom
Conversation
Previously if a `universe_domain` were specified, it would be set in the request for credentials and the storage client options. However, we can derive this value from the credentials themselves. This makes it possible to use Google Application Default credentials without any explicit `universe_domain` configuration because the universe domain is returned automatically. This has been tested with a Google Cloud Dedicated preview instance.
774365f to
f195f56
Compare
stanhu
commented
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if a
universe_domainwere specified, it would be set in the request for credentials and the storage client options. However, we can automatically derive this value from the credentials themselves. This makes it possible to use Google Application Default credentials without any explicituniverse_domainconfiguration because the universe domain is returned automatically.This has been tested with a Google Cloud Dedicated preview instance.