Drop xerrors since functionality is merged to errors in std lib#225
Drop xerrors since functionality is merged to errors in std lib#225arvenil wants to merge 1 commit intogoogle:masterfrom arvenil:drop_xerrors
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks for the PR, but we can't accept this. The new errors API was added in go1.14, but our current minimally supported version is go1.8. The |
|
Hi, makes sense, feel free to close it. However I'm suprised since people using older golang version can always download older go-cmp version 🤷. |
It's not quite that simple. Suppose there is module A at version v1.5 and that module depends on cmp at version v0.6 (with go1.14 as the minimum support). If you're constrained to an old version of Go and want to use [email protected], you're stuck since it requires you to use [email protected], which requires that you use go1.14. Closing this PR since we won't get to this point for at least a year or more. |
Drop the only dependency since all functionality from xerrors used in go-cmp is now merged to errors in standarad library.