cmp/cmpopts: use errors.Is with ≥go1.13 in compareErrors#251
Merged
dsnet merged 1 commit intogoogle:masterfrom Feb 5, 2021
Merged
cmp/cmpopts: use errors.Is with ≥go1.13 in compareErrors#251dsnet merged 1 commit intogoogle:masterfrom
dsnet merged 1 commit intogoogle:masterfrom
Conversation
Contributor
Author
dsnet
reviewed
Feb 4, 2021
dsnet
reviewed
Feb 4, 2021
dsnet
reviewed
Feb 4, 2021
Collaborator
|
What's the effect of this PR on the |
Use the standard definition of errors.Is to implement compareErrors with ≥go1.13. Retain the implementation using golang.org/x/xerrors for versions <go1.13. This will allow packages using newer Go versions and already relying on the errors package to get rid of the transitive dependency on golang.org/x/xerrors.
tklauser
force-pushed
the
go-1.13-use-stdlib-errors
branch
from
6cfaebc to
e490247
Compare
Contributor
Author
As far as I can tell there will be no effect on the However, a package importing |
Collaborator
|
The presence of Anyways, I agree this change in a step in the direction we want to go. |
dsnet
approved these changes
Feb 4, 2021
This was referenced Mar 6, 2021
Closed
Closed
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the standard definition of errors.Is to implement compareErrors with
≥go1.13. Retain the implementation using golang.org/x/xerrors for versions <go1.13.
This will allow packages using newer Go versions and already relying on
the errors package to get rid of the transitive dependency on
golang.org/x/xerrors.