Conversation
Now that Go 1.13 is the minimum version, we can use the reflect.Value.IsZero method instead of our own internal/value.IsZero function. Interestingly, our IsZero function pre-dates the IsZero method, but fortunately has the exact same semantics, since both are targetting semantics defined by the Go language specification.
|
I like code deletion. It's when I feel most productive. |
|
Bleh. GitHub actions is confused. It's hosed on trying to test for Go 1.11 and 1.12 when we have removed those from our CI. @neild Can you force merge this? |
|
It looks like github actions it not running tests for 1.11/1.12, but those checks are marked as "required" in project settings. That can be fixed under project settings: https://github.com/google/go-cmp/settings/branches, under "Require status checks to pass before merging" |
|
Fixed the branch settings to no longer check for 1.11/1.12. |
|
hi, Error: Step 7/11 : RUN go get github.com/google/go-cmp/cmp |
|
What version of Go are you using? The minimally supported version of Go by this package is Go 1.13. The |
|
Thanks for your reply. We are installing |
|
|
|
we will plan to update to go 1.13. Thanks. |
4 participants
Now that Go 1.13 is the minimum version, we can use the reflect.Value.IsZero
method instead of our own internal/value.IsZero function.
Interestingly, our IsZero function pre-dates the IsZero method,
but fortunately has the exact same semantics, since both are targetting
semantics defined by the Go language specification.