Adjust heuristic for line-based versus byte-based diffing#299
Merged
Conversation
dsnet
force-pushed
the
dsnet/many-escape
branch
2 times, most recently
from
fd1e94b to
35c24e6
Compare
Collaborator
Author
|
Friendly ping @neild |
If the string has many characters that require escape sequences to print, then we need to take that into consideration and avoid byte-by-byte diffing.
dsnet
commented
Jul 20, 2022
| ... // 3 identical lines | ||
| """ | ||
| ) | ||
| >>> TestDiff/Reporter/ManyEscapeCharacters |
Collaborator
Author
There was a problem hiding this comment.
This used to print:
strings.Join({
"[\n\t{\"Base32\": \"N",
- "A",
+ "B",
"======\"},\n\t{\"Base32\": \"NBSQ====\"},\n\t{\"Base32\": \"NBSWY===\"},\n\t{\"B",
"ase32\": \"NBSWY3A=\"},\n\t{\"Base32\": \"NBSWY3DP\"}\n]",
}, "")
Collaborator
Author
|
Friendly ping @neild . We're using cmp to display some diffs of things at Tailscale and this would improve the verbosity of that service. |
neild
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the string has many characters that require escape sequences to print,
then we need to take that into consideration and avoid byte-by-byte diffing.