Add flag for skipping javadoc formatting#149
Closed
Kurt-Bonatz wants to merge 2 commits intogoogle:masterfrom
Closed
Add flag for skipping javadoc formatting#149Kurt-Bonatz wants to merge 2 commits intogoogle:masterfrom
Kurt-Bonatz wants to merge 2 commits intogoogle:masterfrom
Conversation
Adds the command line flag `--skip-javadoc-formatting` to enable skipping javadoc formatting. Only the HTML formatting of javadoc is skipped, not things like fixing indentation, missing asterisks and trimming. This commit does not attempt to solve issues that arise when using other formatting standards, simply just to preserve the text inside of the javadoc. For examples, see the tests added to JavadocFormattingTest. Issue: google#139
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Author
|
I have signed the CLA |
|
CLAs look good, thanks! |
Ran the autoformatter over the prior changes to keep style in line with the rest of the code base. Also changed from JavaDoc to Javadoc to also reflect pre-existing code.
Closed
Merged
cpovirk
pushed a commit
that referenced
this pull request
Nov 12, 2019
Fixes #139, #149 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=279811849
cpovirk
pushed a commit
that referenced
this pull request
Nov 12, 2019
Fixes #139, #149 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=279811849
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the command line flag
--skip-javadoc-formattingto enableskipping javadoc formatting. Only the HTML formatting of javadoc is
skipped, not things like fixing indentation, missing asterisks and
trimming. This commit does not attempt to solve issues that arise when
using other formatting standards, simply just to preserve the text
inside of the javadoc. For examples, see the tests added to
JavadocFormattingTest.
Issue: #139