Add flag to select tfrt backend for CPU.#7042
Merged
copybara-service[bot] merged 1 commit intojax-ml:mainfrom Jun 22, 2021
Merged
Add flag to select tfrt backend for CPU.#7042copybara-service[bot] merged 1 commit intojax-ml:mainfrom
copybara-service[bot] merged 1 commit intojax-ml:mainfrom
Conversation
0fad40b to
a2d19be
Compare
hawkinsp
reviewed
Jun 22, 2021
jax/lib/xla_bridge.py
Outdated
| else: | ||
| register_backend_factory('cpu', xla_client.make_cpu_client, | ||
| priority=0) | ||
| register_backend_factory('cpu', xla_client.make_cpu_client, |
Collaborator
There was a problem hiding this comment.
Should this registration still be here? I think it's subsumed by the ones above.
a2d19be to
00a159f
Compare
hawkinsp
approved these changes
Jun 22, 2021
00a159f to
1882bca
Compare
1882bca to
132a542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new TFRT CPU backend has been running without issues internally for a while.
Adding an option to use it in open source.
Benchmarks show significant dispatch performance improvements (wall time)