python: Named component accessors for S2Point#268
Merged
jmr merged 2 commits intogoogle:masterfrom Aug 24, 2022
Merged
Conversation
Contributor
|
This overlaps with a change that I proposed: e8f4ae4 I don't know which way is better. I'd be happy with either. |
Contributor
Author
|
The changes do not conflict, but complement each other. I hope that one small change will be quickly reviewed and accepted. |
Member
|
Please add a test to |
Contributor
Author
Done. Please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this small change we can code something like this:
to render this:
and not only...