value_lexicon: Fix build with abseil LTS 2023-08-02#334
Merged
jmr merged 1 commit intogoogle:masterfrom Nov 22, 2023
Merged
Conversation
jmr
reviewed
Nov 22, 2023
| namespace absl { | ||
| namespace hash_internal { | ||
| template <typename T> | ||
| struct Hash; |
Member
There was a problem hiding this comment.
I'm sure this was added because something was failing, but it's obviously wrong and we shouldn't be depending on abseil internals. I guess we can play whack-a-bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the build error like:
Because absl::hash_internal::Hash is not used in this file, it's safe to remove it.