Merged
Conversation
Member
jmr
commented
Apr 2, 2024
jmr
commented
- Remove glog and gflags dependencies. Now abseil-cpp is used.
- ABSL_LOG macros are used instead of S2_LOG
- The indirection could be added back if requested
- ABSL_CHECK macros are used instead of S2_CHECK
- S2_DEFINE_ now forwards to ABSL_FLAG
- ABSL_LOG macros are used instead of S2_LOG
- New files:
- s2chain_interpolation_query
- s2density_tree
- s2gmock_matchers
- s2fractal
- s2shapeutil_count_vertices
- s2shapeutil_edge_wrap
- Requires abseil-cpp LTS 20240116
- New S2Shape functions:
- Incoming
- Outgoing
- IncidentOn
- Remove S2Shape::id()
- New predicates in s2predicates.h
- S2Region::GetCellUnionBound is now pure virtual
* Remove glog and gflags dependencies; use abseil-cpp instead. * Use ABSL_LOG macros instead of S2_LOG * Use ABSL_CHECK macros instead of S2_CHECK * Require abseil-cpp LTS 20240116 * Remove Python SWIG. (This will be maintained in the github branch.) * Add new files: * s2chain_interpolation_query * s2density_tree * s2gmock_matchers * s2fractal * s2shapeutil_count_vertices * s2shapeutil_edge_wrap * Remove S2Shape::shape(int) * Add new predicates in s2predicates.h * Make S2Region::GetCellUnionBound pure virtual * Add new S2Shape functions
* Removed glog and gflags dependencies. Now abseil-cpp is used.
* ABSL_LOG macros are used instead of S2_LOG
* The indirection could be added back if requested
* ABSL_CHECK macros are used instead of S2_CHECK
* S2_DEFINE_ now forwards to ABSL_FLAG
* New files:
* s2chain_interpolation_query
* s2density_tree
* s2gmock_matchers
* s2fractal
* s2shapeutil_count_vertices
* s2shapeutil_edge_wrap
* Requires abseil-cpp LTS 20240116
* New S2Shape functions:
* Incoming
* Outgoing
* IncidentOn
* Removed S2Shape::id()
* New predicates in s2predicates.h
* S2Region::GetCellUnionBound is now pure virtual
Contributor
|
Whooo thanks Jesse. |
|
I believe that after this commit, the project no longer compiles with C++14. At least I got errors with this file: With C++17 it works. C++14 is claimed to be supported in a number of places, like the README and CMakeLists.txt. I'm not sure if this was intended and simply the documentation should be updated, or not intended. |
Member
Author
|
That's a mistake. I'll make a new PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.