Merged
Conversation
The code is structured like this:
```
class S2Polyline {
class OwningShape {
std::unique_ptr<S2Polyline> owned_polyline_;
};
};
```
libcxx 16 complains that S2Polyline is not defined at the point where
the dtor of the unique_ptr is called (which is OwningShape's implicitly
declared default destructor in the same header file) (also see [0]).
As a remedy, declare OwningShape's destructor in the source file where
the full declaration of S2Polyline is visible.
[0] https://stackoverflow.com/a/34073093/22422288)
jmr
requested changes
Jul 5, 2024
jmr
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while upgrading LLVM in ClickHouse (which uses s2geometry).
The code is structured like this:
libcxx 16 complains that S2Polyline is not defined at the point where
the dtor of the unique_ptr is called (which is OwningShape's implicitly
declared default destructor in the same header file) (also see [0]).
As a remedy, declare OwningShape's destructor in the source file where
the full declaration of S2Polyline is visible.
[0] https://stackoverflow.com/a/34073093/22422288)