Fixed where cc_configure_extension comes from.#410
Merged
jmr merged 1 commit intogoogle:masterfrom Feb 26, 2025
Merged
Conversation
jmr
reviewed
Feb 26, 2025
jmr
reviewed
Feb 26, 2025
Contributor
Author
|
Not sure why the Mac cmake tests are failing, should be unrelated to Bazel changes? |
Member
Yes, it's unrelated. See #409. I'll delete the Mac tests if we can't fix them soon. If you added a bazel-based test, I wouldn't complain. :) |
jmr
approved these changes
Feb 26, 2025
Member
|
Thanks! |
Wyverald
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Feb 27, 2025
Also added a patch to fix bazelbuild/bazel#24426 (upstreamed in google/s2geometry#410). cc @romanoid-openai
jmr
reviewed
Feb 28, 2025
|
|
||
| # Forces usage of the patched re2 version that marks cc_configure_extension as a | ||
| # dev dep as a workaround for https://github.com/bazelbuild/bazel/issues/24426. | ||
| # TODO: remove once fixed upstream in re2, googletest, and abseil-cpp. |
Member
There was a problem hiding this comment.
@vtsao-openai google/re2@c84a140 has been merged. What needs to happen now?
Contributor
Author
There was a problem hiding this comment.
Ideally a new release of https://github.com/google/re2/releases so we can pull that new release into the BCR and then update googletest in the BCR to use the new version. I think it was googletest that was the problem in the dep graph: bazelbuild/bazel#24426 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: bazelbuild/bazel#24426
Fixes
bazel mod deps.cc @romanoid-openai