Fix some comments in s2builderutil_snap_functions#418
Merged
jmr merged 3 commits intogoogle:masterfrom May 5, 2025
Merged
Conversation
jmr
requested changes
May 5, 2025
|
|
||
| // For IntLatLng snapping, the minimum separation between vertices depends on | ||
| // exponent() and snap_radius(). It can vary between snap_radius() | ||
| // exponent() and snap_radius(). It can vary between 0.471 * snap_radius() |
Member
There was a problem hiding this comment.
How about "It can vary between approximately 0.471 * snap_radius()"? Or "approximately sqrt(2)/3 * snap_radius()"?
jmr
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.