Update to 2025-10-24 google3 version#465
Merged
jmr merged 2 commits intogoogle:masterfrom Oct 24, 2025
Merged
Conversation
* Increase minimum enforced CMake version to 3.11 * Remove `DEFINE_*` flags macros and use `ABSL_FLAG` directly * Modernize `ExactFloat` interface * Replace `exactfloat::is_nan()` with `isnan(const ExactFloat&)` * Replace `ToDouble()` with `explicit operator double()` * Add `fpclassify(const ExactFloat&)` * Add exactfloat_underflow_test * New `S2Cell::IsDistanceLess` and related predicates * Do not use `#pragma STDC FP_CONTRACT off` for gcc to try to prevent warnings. gcc has its own pragma (which was always used) * Switch some `ABSL_LOG(ERROR)`s to `DFATAL`
* Remove `S2_DEFINE_*` flags macros and use `ABSL_FLAG` directly * Modernize `ExactFloat` interface * Replace `exactfloat::is_nan()` with `isnan(const ExactFloat&)` * Replace `ToDouble()` with `explicit operator double()` * Add `fpclassify(const ExactFloat&)` * Add exactfloat_underflow_test * New `S2Cell::IsDistanceLess` and related predicates * Do not use `#pragma STDC FP_CONTRACT off` for gcc to try to prevent warnings. gcc has its own pragma (which was always used) * Switch some `ABSL_LOG(ERROR)`s to `DFATAL`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEFINE_*flags macros and useABSL_FLAGdirectlyExactFloatinterfaceexactfloat::is_nan()withisnan(const ExactFloat&)ToDouble()withexplicit operator double()fpclassify(const ExactFloat&)S2Cell::IsDistanceLessand related predicates#pragma STDC FP_CONTRACT offfor gcc to try toprevent warnings. gcc has its own pragma (which was always
used)
ABSL_LOG(ERROR)s toDFATAL