Increase filesystem module test coverage for storage, service provider, and file facade paths by Copilot · Pull Request #1387 · goravel/framework

Copilot · 2026-03-05T08:47:32Z

Review new PR comments and identify actionable items
Verify recent CI/build failure context via GitHub Actions logs
Apply requested style updates in filesystem tests (mock aliases/types/matchers)
Run targeted filesystem tests
Run final code review and security scan
Reply to newly addressed review comments with commit hash

Original prompt

This section details on the original issue you should resolve

<issue_title>Task 1.4: Filesystem Module - Increase test coverage from 43.65% to 70%</issue_title>
<issue_description>Parent Issue: goravel/goravel#43
Priority: 1
Current Coverage: 43.65% (141/323 lines covered, 156 missed)
Target Coverage: 70%
Estimated Impact: +0.8% overall coverage

Focus Areas

File operations (read, write, delete)

Directory management

Different storage drivers (local, S3, etc.)

Error handling for permissions

Implementation Repository

goravel/framework - filesystem module</issue_description>

Comments on the Issue (you are @copilot in this section)
@hwbrzzl Closing - creating as sub-tasks in goravel/goravel#43 instead

Fixes Task 1.4: Filesystem Module - Increase test coverage from 43.65% to 70% goravel#887

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: hwbrzzl <[email protected]>

codecov · 2026-03-05T09:12:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.99%. Comparing base (29a6104) to head (be0b293).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   69.40%   69.99%   +0.58%     
==========================================
  Files         292      292              
  Lines       19563    19564       +1     
==========================================
+ Hits        13578    13693     +115     
+ Misses       5403     5288     -115     
- Partials      582      583       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hwbrzzl

Overall this PR adds good test coverage for the filesystem module. I've identified a few potential improvements around mock expectations and test assertions that could make the tests more robust.

hwbrzzl · 2026-03-05T09:17:32Z

filesystem/application_service_provider_test.go

+		custom := filesystemmock.NewDriver(t)
+		config.EXPECT().GetString("filesystems.disks.custom.driver").Return("custom").Once()
+		// NewDriver checks "via" as a Driver first, then as a callback.
+		config.EXPECT().Get("filesystems.disks.custom.via").Return(func() (contractsfilesystem.Driver, error) {


The .Twice() expectation seems incorrect here. The comment says NewDriver checks "via" first as Driver then as callback, but typically config.Get() would be called once to retrieve the value, then type assertion/checking happens in code. Unless the implementation really calls Get() twice, this should be .Once(). Consider verifying the actual implementation behavior.

hwbrzzl · 2026-03-05T09:17:32Z

filesystem/application_service_provider_test.go

+	t.Run("returns error for invalid custom driver", func(t *testing.T) {
+		config := configmock.NewConfig(t)
+		config.EXPECT().GetString("filesystems.disks.custom.driver").Return("custom").Once()
+		// NewDriver checks "via" as a Driver first, then as a callback.


Same issue as line 83 - .Twice() may be incorrect if config.Get() is only called once by the implementation. This could cause test failures if the implementation changes or may not properly catch bugs if the expectation doesn't match actual behavior.

hwbrzzl · 2026-03-05T09:17:32Z

filesystem/file_test.go

+
+	storage.EXPECT().Disk("s3").Return(driver).Twice()
+	driver.EXPECT().PutFile("uploads", file).Return("uploads/hash.go", nil).Once()
+	driver.EXPECT().PutFileAs("uploads", file, "goravel.go").Return("uploads/goravel.go", nil).Once()


The test calls both Store() and StoreAs() but sets .Twice() expectation for storage.Disk(). If either method implementation changes to call Disk() multiple times or reuse the driver, this test will fail. Consider splitting into two separate test cases or using .Times(2) with a clearer comment explaining why it's called twice.

hwbrzzl · 2026-03-05T09:17:32Z

filesystem/file_test.go

+		name:   "goravel.txt",
+		disk:   "local",
+	}
+


Minor: The test writes 9 bytes ("framework") and asserts Size() returns exactly 9. While correct, consider using len("framework") in the assertion for better readability: assert.Equal(t, int64(len("framework")), size). This makes it clearer the size matches the written content.

hwbrzzl · 2026-03-05T09:24:28Z

@copilot There are some comments, but they may not all be correct. Check and fix them if needed.

Co-authored-by: hwbrzzl <[email protected]>

hwbrzzl

@copilot

hwbrzzl · 2026-03-05T09:57:13Z

filesystem/application_service_provider_test.go

+	configmock "github.com/goravel/framework/mocks/config"
+	filesystemmock "github.com/goravel/framework/mocks/filesystem"
+	foundationmock "github.com/goravel/framework/mocks/foundation"


Suggested change

configmock "github.com/goravel/framework/mocks/config"

filesystemmock "github.com/goravel/framework/mocks/filesystem"

foundationmock "github.com/goravel/framework/mocks/foundation"

mocksconfig "github.com/goravel/framework/mocks/config"

mocksfilesystem "github.com/goravel/framework/mocks/filesystem"

mocksfoundation "github.com/goravel/framework/mocks/foundation"

Updated in be0b293. Switched the mock import aliases in this test file to mocksconfig, mocksfilesystem, and mocksfoundation.

hwbrzzl · 2026-03-05T09:58:31Z

filesystem/application_service_provider_test.go

+
+	t.Run("register returns error when config facade not set", func(t *testing.T) {
+		app := foundationmock.NewApplication(t)
+		app.EXPECT().Singleton(binding.Storage, mock.Anything).Run(func(_ interface{}, callback func(contractsfoundation.Application) (interface{}, error)) {


Use mock.AnythingOfType instead of mock.Anything, use any instead of interface{}.

Addressed in be0b293. I replaced mock.Anything with mock.AnythingOfType("func(foundation.Application) (interface {}, error)") and updated local callback helper signatures to use any.

hwbrzzl · 2026-03-05T09:59:43Z

filesystem/file_test.go

 	configmock "github.com/goravel/framework/mocks/config"
+	filesystemmock "github.com/goravel/framework/mocks/filesystem"


Suggested change

configmock "github.com/goravel/framework/mocks/config"

filesystemmock "github.com/goravel/framework/mocks/filesystem"

mocksconfig "github.com/goravel/framework/mocks/config"

mocksfilesystem "github.com/goravel/framework/mocks/filesystem"

Updated in be0b293. The imports in filesystem/file_test.go now use mocksconfig and mocksfilesystem aliases.

Co-authored-by: hwbrzzl <[email protected]>

* chore: Update upgrade DB packages (#1374) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Internalize file rotation logic from goravel/file-rotatelogs (#1375) * Initial plan * Implement internal file rotation to replace goravel/file-rotatelogs Co-authored-by: hwbrzzl <[email protected]> * Improve cleanup logic with glob pattern matching and add comprehensive tests Co-authored-by: hwbrzzl <[email protected]> * Address code review feedback: fix trailing whitespace, add cleanup wait, and make tests deterministic Co-authored-by: hwbrzzl <[email protected]> * optimize --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> Co-authored-by: Bowen <[email protected]> * chore: Update non-major dependencies (#1373) * chore: Update non-major dependencies * optimize * optimize * renovate/non-major-dependencies * optimize --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bowen <[email protected]> * feat: [#726] Add HTTP server and client telemetry instrumentation [5] (#1326) * add http middleware * add http transport * optimise http telemetry package * add test cases for Telemetry middleware * add auto instrumentation configs * add config to enable Telemetry for http clients * add docs for config facade * add ConfigFacade nil warning * disable default telemetry * optimise transport * add kill switch for instrumentation * update the stubs * remove unnecessary handler * optimise log instrumentation * move route registration in the end * lazily initialize middleware and transport to work with new application_builder * optimise channel test * optimise channel test * accept telemetry facade as an input instead of using global instance * use a callback to resolve the telemetry facade instance * optimise grpc handler to remove usage of telemetry and config facade * optimise the grpc handler * use telemetry transport if enabled * optimise http auto instrumentation * optimize log test cases * optimise * optimise * optimise * optimise * revert PR#1357 * fix log test cases * revert GRPC changes * optimise middleware * remove zipkin trace driver * correct GRPC enable condition * correct http transport enable condition * correct log channel enable condition * update go mod * fix test cases * fix test cases * fix test cases * fix tests --------- Co-authored-by: Bowen <[email protected]> * chore: optimize runner tests for Windows (#1377) Co-authored-by: Bowen <[email protected]> * chore: Update non-major dependencies (#1378) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: runner stuck (#1381) * fix: runner stuck * optimize * optimize * optimize * optimize * optimize * chore: Update non-major dependencies (#1382) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: [#849] Add table support to the console context (#1380) * add table function in cli * add test cases for new method Table * update mocks * add column level styles * fix lint error * move style vars to new file * add GlobalHuhTheme * update go mod tidy * feat: [#546] artisan command up and down to set website Maintenance mode (#1198) * Add up and down command * Use file helper to create files and add unit tests * Fix the foundation.App dependency * Use support/path instead of foundation.App * Add unit test case * Add some missing checks * Add more missing checks * One more * Fix tmpfile path * Use T.TempDir instead of os.TempDir in tests * Add reason to the down command * Add option to the tests * Change the maintenance file name * close created file handles * Defer abort * Fix the linter issue * Add more options to the down command * Use options * Check for maintenance mode respond * Fix down_command_test * Add more unit test cases * Fix more lint issues * Fix lint issue * fix tests * fix tests * fix tests * fix tests * Address PR comments * Fix check_for_maintenance_test * Check Aborts in check_for_maintenance * Rename check_for_maintenance_mode * Fix and Write more unit tests for check_for_maintenance_mode middleware * fix down command * Fix down_command_test * Fix up_command --------- Co-authored-by: Bowen <[email protected]> * feat: Laravel-style Collection library (#1134) Merges comprehensive Collection library with 100+ methods for data manipulation. Implements both eager (Collection) and lazy (LazyCollection) evaluation strategies. Closes goravel/goravel#566 Follow-up improvements tracked in: goravel/goravel#883 * Increase route module coverage for factory, provider, and runner wiring paths (#1384) * Initial plan * test(route): cover route factory and service provider paths Co-authored-by: hwbrzzl <[email protected]> * optimize * optimize --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> Co-authored-by: Bowen <[email protected]> * chore: optimize interface (#1389) * Increase crypt module coverage by exercising AES key validation and failure paths (#1385) * Initial plan * test: add crypt AES edge-case coverage Co-authored-by: hwbrzzl <[email protected]> * test: improve readability of crypt key-length cases Co-authored-by: hwbrzzl <[email protected]> * test: address crypt PR feedback and simplify test structure Co-authored-by: hwbrzzl <[email protected]> * test: use configmock EXPECT style in TestNewAES Co-authored-by: hwbrzzl <[email protected]> * test: standardize config mock setup across aes tests Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * Increase filesystem module test coverage for storage, service provider, and file facade paths (#1387) * Initial plan * Add filesystem application and provider coverage tests Co-authored-by: hwbrzzl <[email protected]> * Polish filesystem coverage tests after review feedback Co-authored-by: hwbrzzl <[email protected]> * Refine filesystem tests based on review feedback Co-authored-by: hwbrzzl <[email protected]> * Apply review style suggestions in filesystem tests Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * Increase mail module test coverage to 70%+ with focused unit tests (#1386) * Initial plan * test(mail): add focused unit coverage for application, options, and service provider Co-authored-by: hwbrzzl <[email protected]> * test(mail): address review feedback on test specificity and readability Co-authored-by: hwbrzzl <[email protected]> * test(mail): merge application unit tests and remove untyped mock matchers Co-authored-by: hwbrzzl <[email protected]> * test(mail): deduplicate matchers and tighten queue job assertion Co-authored-by: hwbrzzl <[email protected]> * test(mail): use AnythingOfType and any in application tests Co-authored-by: hwbrzzl <[email protected]> * test(mail): derive bind callback type string from any signature Co-authored-by: hwbrzzl <[email protected]> * test(mail): simplify bind callback type matcher Co-authored-by: hwbrzzl <[email protected]> * test(mail): use AnythingOfType for template render expectations Co-authored-by: hwbrzzl <[email protected]> * test(mail): restore specific MatchedBy assertions per review clarification Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * Increase hash module coverage with targeted tests for driver selection and service provider paths (#1388) * Initial plan * test: increase hash module coverage for driver and provider paths Co-authored-by: hwbrzzl <[email protected]> * test: cover hash provider and driver selection paths Co-authored-by: hwbrzzl <[email protected]> * test: address hash module review feedback Co-authored-by: hwbrzzl <[email protected]> * test: merge hash module tests into application_test Co-authored-by: hwbrzzl <[email protected]> * test: use EXPECT API in hash service provider test Co-authored-by: hwbrzzl <[email protected]> * test: use any alias in hash singleton callback test Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * chore: add AI instructions file (#1393) * Increase core framework coverage via targeted service provider and builder-path tests (#1391) * Initial plan * Add service provider coverage tests for core modules Co-authored-by: hwbrzzl <[email protected]> * Expand core module coverage tests and validate suite Co-authored-by: hwbrzzl <[email protected]> * Revert unintended test module dependency drift Co-authored-by: hwbrzzl <[email protected]> * Address actionable PR review suggestions in coverage tests Co-authored-by: hwbrzzl <[email protected]> * Finalize review feedback handling Co-authored-by: hwbrzzl <[email protected]> * Revert unintended tests module dependency updates Co-authored-by: hwbrzzl <[email protected]> * Tighten provider test matchers per review feedback Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * Increase infrastructure module coverage by adding Process/Packages/Log/Schedule tests and fixing errors.As target forwarding (#1392) * Initial plan * test(errors): cover As/Unwrap/Ignore/Join edge cases Co-authored-by: hwbrzzl <[email protected]> * test(errors): use wrapped error in As coverage test Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module file changes Co-authored-by: hwbrzzl <[email protected]> * test: add coverage for process packages log schedule modules Co-authored-by: hwbrzzl <[email protected]> * test: refine schedule coverage tests per review Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module dependency updates Co-authored-by: hwbrzzl <[email protected]> * test: assert boot no-panic in log and process providers Co-authored-by: hwbrzzl <[email protected]> * chore: finalize review feedback responses for boot test assertions Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module file changes Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * test: expand service-layer coverage across Event, Queue, gRPC, Cache, and Console (#1390) * Initial plan * test(event): cover service provider and queued listener dispatch paths Co-authored-by: hwbrzzl <[email protected]> * chore: finalize event coverage validation Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module dependency updates Co-authored-by: hwbrzzl <[email protected]> * test(event): address review suggestions for robust command matching and queue error path Co-authored-by: hwbrzzl <[email protected]> * chore: finalize PR feedback follow-up Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module file updates Co-authored-by: hwbrzzl <[email protected]> * test: add focused coverage cases for queue grpc cache console Co-authored-by: hwbrzzl <[email protected]> * test: clarify queue nil args in empty chain test Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module dependency updates Co-authored-by: hwbrzzl <[email protected]> * test: avoid nil context in console usage-error test Co-authored-by: hwbrzzl <[email protected]> * chore: finalize lint ci fix validation Co-authored-by: hwbrzzl <[email protected]> * chore: revert unintended tests module dependency drift Co-authored-by: hwbrzzl <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: hwbrzzl <[email protected]> * chore: Update non-major dependencies (#1399) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add generate flag to artisan build command (#1402) * feat: [#911] add query context accessor (#1401) * chore: optimize agents (#1396) * chore: optimize agents * optimize * address comments * Initial plan * fix: backport migrate rollback default handling to v1.17.x Co-authored-by: hwbrzzl <[email protected]> * chore: align branch tree with v1.17.x before backporting rollback fix Co-authored-by: hwbrzzl <[email protected]> * optimize * optimize --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bowen <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: hwbrzzl <[email protected]> Co-authored-by: krishan kumar <[email protected]> Co-authored-by: Bowen <[email protected]> Co-authored-by: Mohan Raj <[email protected]> Co-authored-by: Ahmed M. Ammar <[email protected]> Co-authored-by: 耗子 <[email protected]> Co-authored-by: ALMAS <[email protected]>

Initial plan

e0350d6

Copilot AI assigned Copilot and hwbrzzl Mar 5, 2026

Copilot started work on behalf of hwbrzzl March 5, 2026 08:47 View session

Copilot AI and others added 2 commits March 5, 2026 08:54

Add filesystem application and provider coverage tests

34eca3e

Co-authored-by: hwbrzzl <[email protected]>

Polish filesystem coverage tests after review feedback

36702ba

Co-authored-by: hwbrzzl <[email protected]>

Copilot AI changed the title ~~[WIP] Increase test coverage for filesystem module to 70%~~ Increase filesystem module test coverage for storage, service provider, and file facade paths Mar 5, 2026

Copilot finished work on behalf of hwbrzzl March 5, 2026 08:59

hwbrzzl added the 🚀 Review Ready label Mar 5, 2026

hwbrzzl marked this pull request as ready for review March 5, 2026 09:13

hwbrzzl requested a review from a team as a code owner March 5, 2026 09:13

hwbrzzl reviewed Mar 5, 2026

View reviewed changes

Copilot started work on behalf of hwbrzzl March 5, 2026 09:24 View session

Refine filesystem tests based on review feedback

56537c0

Co-authored-by: hwbrzzl <[email protected]>

Copilot finished work on behalf of hwbrzzl March 5, 2026 09:34

hwbrzzl reviewed Mar 5, 2026

View reviewed changes

Copilot started work on behalf of hwbrzzl March 5, 2026 10:00 View session

Apply review style suggestions in filesystem tests

be0b293

Co-authored-by: hwbrzzl <[email protected]>

Copilot finished work on behalf of hwbrzzl March 5, 2026 10:09

hwbrzzl approved these changes Mar 5, 2026

View reviewed changes

hwbrzzl merged commit 38e47ab into master Mar 5, 2026
16 of 17 checks passed

hwbrzzl deleted the copilot/increase-test-coverage-filesystem branch March 5, 2026 10:13

		configmock "github.com/goravel/framework/mocks/config"
		filesystemmock "github.com/goravel/framework/mocks/filesystem"

Conversation

Copilot AI commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Focus Areas

Implementation Repository

Comments on the Issue (you are @copilot in this section)

Uh oh!

codecov bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl commented Mar 5, 2026

Uh oh!

hwbrzzl left a comment

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

hwbrzzl Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited

Loading