Allow GPUTexture where GPUTextureView is used#4407
Merged
beaufortfrancois merged 4 commits intomainfrom Jul 9, 2025
Merged
Conversation
greggman
requested changes
Jun 25, 2025
src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts
Outdated
Show resolved
Hide resolved
beaufortfrancois
force-pushed
the
use-texture
branch
2 times, most recently
from
3f4bf23 to
a4b0960
Compare
beaufortfrancois
force-pushed
the
use-texture
branch
from
a4b0960 to
7e20a09
Compare
greggman
approved these changes
Jun 25, 2025
Collaborator
Author
|
Note that I'll wait for gpuweb/types#186 to be merged. |
Collaborator
Author
|
@greggman Do you think I shall update more tests for this feature or are we good with those validation tests? |
Contributor
|
I think it's fine with these tests |
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 11, 2025
…`s are allowed r=#webgpu-reviewers! gpuweb/cts#4407 gpuweb/gpuweb#5228
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 11, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 12, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 12, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 17, 2025
…`s are allowed r=webgpu-reviewers,webidl,smaug,nical Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
4 tasks
ErichDonGubler
added a commit
to erichdongubler-mozilla/gpuweb-cts
that referenced
this pull request
Aug 23, 2025
…one_*_attachment` tests This is a bug in gpuweb#4407, where this coverage was originally intended to be introduced.
|
|
||
| g.test('attachments,one_color_attachment') | ||
| .desc(`Test that a render pass works with only one color attachment.`) | ||
| .paramsSubcasesOnly(u => u.combine('bindTextureResource', [false, true] as const)) |
Member
There was a problem hiding this comment.
bindTextureResource is not actually being used in both of these one_*_attachment tests, so we're not actually exercising the GPUTexture case. Filed a fix in #4447.
ErichDonGubler
added a commit
to erichdongubler-mozilla/gpuweb-cts
that referenced
this pull request
Aug 23, 2025
…one_*_attachment` tests This is a bug in gpuweb#4407, where this coverage was originally intended to be introduced.
greggman
pushed a commit
to greggman/cts
that referenced
this pull request
Oct 14, 2025
…one_*_attachment` tests (gpuweb#4447) This is a bug in gpuweb#4407, where this coverage was originally intended to be introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec PR: gpuweb/gpuweb#5228
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.