Skip to content

Workgroup size dimensions can be pipeline-overrideable constants#1444

Merged
kdashg merged 1 commit intogpuweb:mainfrom
dneto0:issue-1442
Feb 23, 2021
Merged

Workgroup size dimensions can be pipeline-overrideable constants#1444
kdashg merged 1 commit intogpuweb:mainfrom
dneto0:issue-1442

Conversation

@dneto0
Copy link
Contributor

@dneto0 dneto0 commented Feb 17, 2021

Fixes #1442

@dneto0 dneto0 requested review from kvark and litherum February 17, 2021 22:01
@dneto0 dneto0 added the wgsl WebGPU Shading Language Issues label Feb 17, 2021
@dneto0 dneto0 added this to the MVP milestone Feb 17, 2021
@dneto0
Copy link
Contributor Author

dneto0 commented Feb 17, 2021

cc: @alan-baker

@github-actions
Copy link
Contributor

Previews, as seen at the time of posting this comment:
WebGPU | IDL
WGSL
2216e49

@dneto0 dneto0 changed the title Workgroup size dimensions can be module-scope constants Workgroup size dimensions can be pipeline-overrideable constants Feb 18, 2021
@github-actions
Copy link
Contributor

Previews, as seen at the time of posting this comment:
WebGPU | IDL
WGSL
b750ab4

Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@litherum
Copy link
Contributor

How is this implemented on D3D?

@kvark
Copy link
Contributor

kvark commented Feb 19, 2021

@litherum as indicated in #1442 (comment),
if an implementation generates HLSL (which pretty much has to happen at pipeline creation time), then it just inserts the specialization values into the text. If it implements DXIL ahead of time, it just patches the values in it before creating the DX12 pipeline.

@dneto0
Copy link
Contributor Author

dneto0 commented Feb 22, 2021

Discussed during F2F 2021-02-22

@kdashg kdashg merged commit 4813cbb into gpuweb:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wgsl WebGPU Shading Language Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow workgroup size components to be pipeline-overrideable constants

4 participants