Require indirect draw calls use a firstInstance of 0#1928
Merged
Conversation
Contributor
kvark
approved these changes
Jul 13, 2021
Contributor
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Thank you, it reads very reasonable!
kainino0x
approved these changes
Jul 13, 2021
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2021
SHA: 69d9780 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2021
SHA: 69d9780 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 13, 2021
SHA: 69d9780 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1878
Could use a bit more "validation" at the queue level to make the no-op behavior explicit, but given that the whole spec needs to be better about that this didn't seem like the right place to start blazing that particular trail.
Preview | Diff