Allow arrays with pipeline-overridable element count, as store type for workgroup variable#2347
Merged
dneto0 merged 1 commit intogpuweb:mainfrom Dec 8, 2021
Merged
Conversation
Contributor
Author
|
Keeping this as draft until #2104 lands. |
Contributor
Contributor
|
last commit LGTM |
da23ff1 to
7494bf6
Compare
Contributor
Author
|
Rebased, and:
|
kvark
approved these changes
Dec 3, 2021
kdashg
approved these changes
Dec 8, 2021
Contributor
WGSL meeting minutes 2021-12-07
|
…or workgroup variable
* Refines "fixed-footprint" to add subcategory of "creation-fixed footprint",
to mean a plain type whose memory footprint is fixed at shader
creation time. The "fixed-footprint" remains defined as a plain type
whose memory footprint is fixed by the pipline-creation time.
* Allow element count on a fixed-size array to be an overridable
module-scope constant.
* Later I expect we'll have a proper category and name for pipeline-constexpr
and we can patch this up at that time.
* Refine the rules about when two array types are the same.
* Refine the rule about initial value of a workgroup variable.
* Previously "fixed-size array" meant element count was a
shader-creatio-time constant. Now it allows pipeline-creation
constant, so revisit all uses of "fixed-size array" and further
qualify with "with creation-fixed footprint" in the intended places:
In particular:
- array element must be fixed-footprint.
- structure member that is fixed-size array must be fixed-footprint
* Note and provide examples that the store type for a workgroup variable
may have an element count that is pipeline-overridable.
It has fixed footprint but not necessarily creation-time fixed footprint.
* Editorially emphasize that type constructors only create constructible
types.
Fixes: gpuweb#2024
7494bf6 to
29b52d1
Compare
Contributor
Author
|
Rebased, and resolved a trivial conflict. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2024