Fill out scope explanations and collective operations#2351
Merged
dneto0 merged 2 commits intogpuweb:mainfrom Nov 29, 2021
Merged
Fill out scope explanations and collective operations#2351dneto0 merged 2 commits intogpuweb:mainfrom
dneto0 merged 2 commits intogpuweb:mainfrom
Conversation
* Fix the memory scope for non-private reads and writes missed in gpuweb#2297 * only atomics have device memory scope * Define and explain memory and execution scopes * add links in atomic and sync built-in function sections * Define a quad for the purpose of an implicit execution scope on derivatives * Remove todos from collective operations * fill out barrier, defining control barrier
Contributor
dneto0
requested changes
Nov 29, 2021
Contributor
dneto0
left a comment
dneto0
left a comment
There was a problem hiding this comment.
Looking good.
Suggesting some small editorial changes.
wgsl/index.bs
Outdated
|
|
||
| When an invocation performs a scoped operation, it will affect one or two sets | ||
| of invocations. | ||
| These sets are the <dfn noexport>memory scope</dfn> and the <dfn |
Contributor
There was a problem hiding this comment.
Editorially I'd make these forward references, and put the defining tags at the sentences on lines 7413.
The <dfn>memory scope</dfn> of an operation specifies the set of invocations to
which the operation will be visible....
The "will be visible" is a little bit mysterious. How about:
The <dfn>memory scope</dfn> of an operation specifies the set of invocations
whose view of memory will be affected by that operation.
or
The <dfn>memory scope</dfn> of an operation specifies the set of invocations
whose interactions with memory will be affected by that operation.
* move definitions to more appropriate locations * attempt to further clarify memory scope
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derivatives