Enable dynamic indexing on matrix and array values#2427
Merged
dneto0 merged 1 commit intogpuweb:mainfrom Dec 21, 2021
Merged
Conversation
Contributor
kvark
approved these changes
Dec 20, 2021
Contributor
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Sad to see SPIR-V value semantics going out of the window :(
Contributor
Author
I'm sadder we don't have 'break if' and 'break unless'. |
Contributor
Author
|
Breadcrumbs: this reverses the effect of #1801 |
jrprice
added a commit
to jrprice/gpuweb
that referenced
this pull request
Jan 7, 2022
We re-enabled dynamically indexing into non-ref arrays and matrices in gpuweb#2427, as discussed in gpuweb#1782.
ben-clayton
added a commit
to ben-clayton/Tint
that referenced
this pull request
Jan 11, 2022
Spec change: gpuweb/gpuweb#2427 Reverses: tint:867 This reverts and fixes commits: b6fdcc5 10442ef Added a bunch of end-to-end tests. Fixed: tint:1352 Change-Id: I34968243bbec1cab838c8ba50a6f027146bbfd06 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/75401 Reviewed-by: David Neto <[email protected]> Reviewed-by: James Price <[email protected]> Kokoro: Kokoro <[email protected]> Commit-Queue: Ben Clayton <[email protected]>
dneto0
pushed a commit
that referenced
this pull request
Jan 12, 2022
This was referenced Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1782