bgra8unorm-storage only enables write-only#4741
Merged
Conversation
Fixes #4377 Updates the plain color texture table to separate out read-only and write-only storage bindings. bgra8unorm is only given write-only access if the feature is enabled and never given read-only access. All other formats retain the same access as before.
Contributor
|
Previews, as seen when this build job started (716c25c): |
kainino0x
approved these changes
Jul 18, 2024
Contributor
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
LGTM after today's meeting
kainino0x
added
the
needs-cts-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4377
Updates the plain color texture table to separate out read-only and write-only storage bindings. bgra8unorm is only given write-only access if the feature is enabled and never given read-only access. All other formats retain the same access as before.