Remove maxInterStageShaderComponents#4783
Merged
kainino0x merged 1 commit intogpuweb:mainfrom Aug 28, 2024
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (1696617): |
Contributor
Author
|
For the record here's how I'm thinking we can deprecate/remove this from Chromium (taking slight advantage of #4781):
|
Fixes 4688
Contributor
Author
|
(Rebased with no change after landing #4781) |
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 6, 2024
2 tasks
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Sep 18, 2024
gpuweb/gpuweb@23db3e4...2dc56f2 * Handle device limits being undefined * gpuweb/gpuweb#4781 * Remove the maxInterStageShaderComponents limit * gpuweb/gpuweb#4783 Bug: 368022291 Change-Id: I548a1c2e841aa40feb0234214a9dc75289ffcb13 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/207095 Commit-Queue: Geoff Lang <[email protected]> Reviewed-by: Corentin Wallez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer to land this after #4781, if we accept thatDone and rebasedFixes #4688