Allow GPUTexture where GPUTextureView is used#5228
Merged
dneto0 merged 10 commits intogpuweb:mainfrom Jul 3, 2025
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (b3898a4): |
8 tasks
toji
reviewed
Jun 25, 2025
Member
toji
left a comment
toji
left a comment
There was a problem hiding this comment.
I missed last weeks meeting so I don't know if this was agreed upon behavior. Doesn't seem like the linked issue reached a resolution, at least.
Assuming that the group has agreed on this, though, the PR looks good. Just a couple of nits.
Contributor
Author
beaufortfrancois
left a comment
beaufortfrancois
left a comment
There was a problem hiding this comment.
@toji Thanks for the review! My understanding from past meeting notes is that it had reached consensus.
kainino0x
reviewed
Jun 28, 2025
kainino0x
added
the
needs-cts-issue
kainino0x
approved these changes
Jul 2, 2025
Contributor
Author
|
@dneto0 Please review |
kainino0x
approved these changes
Jul 2, 2025
Contributor
Author
|
@kainino0x Shall we update webgpu.h as well or is it only for Javascript? |
Contributor
|
@beaufortfrancois no, we'll do this only for Javascript. It's just an implicit |
Member
|
I'm happy to do the Blink change unless this is something you wanted to tackle, @beaufortfrancois? |
Contributor
Author
|
I already had one ;) Feel free to review https://chromium-review.googlesource.com/c/chromium/src/+/6656722 |
kainino0x
pushed a commit
to gpuweb/types
that referenced
this pull request
Jul 7, 2025
This PR reflects the following spec changes: - gpuweb/gpuweb#5228
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 9, 2025
Spec PR: gpuweb/gpuweb#5228 Change-Id: I260164692b6476bb298ec8ad23bf8d1696d68778 Bug: 425906323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6656722 Commit-Queue: Fr <[email protected]> Reviewed-by: Brandon Jones <[email protected]> Cr-Commit-Position: refs/heads/main@{#1484331}
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 11, 2025
…`s are allowed r=#webgpu-reviewers! gpuweb/cts#4407 gpuweb/gpuweb#5228
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 11, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 12, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 12, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
This comment was marked as spam.
This comment was marked as spam.
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 16, 2025
…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 17, 2025
…`s are allowed r=webgpu-reviewers,webidl,smaug,nical Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054
4 tasks
Chainsawkitten
added a commit
to Chainsawkitten/WebGPUReconstruct
that referenced
this pull request
Aug 5, 2025
gpuweb/gpuweb#5228 allows using GPUTexture instead of GPUTextureView in a number of places.
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 12, 2025
No functional changes since the object types are not strongly checked in the Wasm -> JS bridge.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GPUTexture support to the following attributes:
It also updates parts of the WebGPU and WGSL specs that I've missed when adding GPUBuffer in GPUBindingResource with #5193
FIX #5215