Merged
Conversation
This will become bundled in Ruby 3.5 Unfortunately there is no portable way of checking for this. The wmic command is deprecated, though I don't observe this myself on W11 (yet?)
This prevents a deprecation warning
grosser
reviewed
Jun 7, 2024
grosser
reviewed
Jun 7, 2024
grosser
approved these changes
Jun 7, 2024
Owner
grosser
left a comment
grosser
left a comment
There was a problem hiding this comment.
maybe ignore the mutex in the test to make it pass ?
Owner
|
also good enough to just add a skip on ruby 3.3, better than having no ci at all |
Owner
|
lmk if you are ready to merge or want to change something still |
Contributor
Author
|
👍 I'll adress your feedback tomorrow |
The memory leak test fails in CI without changes
Contributor
Author
|
Alright, should be good now. I bumped the sqlite3 version since this older one wouldn't compile on my other machine anymore. There's currently no released rails version that works with 2.x, so pin to 1.4 for now |
Owner
|
awesome work, thx! |
Owner
|
1.25.0 |
This was referenced Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345
I refined my initial approach for this. The PR I linked in the issue for
ruby-concurrencygot merged and released.I tried adding CI on windows for this but didn't quite manage, the mysql gem fails to compile. I also tried adding Ruby 3.3 to the matrix but there's one memory leak test that consistently fails:
So I just bump
actions/checkoutto prevent a deprecation warning about old node versions.