Issue commit() right before "non-transactional" DDL command starts#2987
Issue commit() right before "non-transactional" DDL command starts#2987andreitokar merged 4 commits intoh2database:masterfrom
Conversation
|
This approach looks cleaner for me too, but, again, what about other DDL commands? In this branch there are about 28 calls to |
|
Ok, I got your point now, and it looks even messier than before. I was checking all access to transactional / isTransactional() (and even then I've missed AlterTableAddConstraint), but majority of those commands just always call commit() without any checks, assuming it's non-transactional. My bad. |
…te() instead of Prepared.update()
From my point of view all DDL commands should preserve / restore the previous auto-commit status on their completion. Users don't expect it to be changed anywhere. But we also have an undocumented I don't think that new assertions in |
Agree, it was just a quick way to verify my assumption. |
|
The unusual failure in |
|
@katzyn, If you say so, because I am not 100% sure. Unfortunately I can't reproduce it, might be JDK-dependant. |
This PR also intended to fix #2590.
It is an alternative to PR #2986. A little cleaner, IMHO.