Update copyright years and fix building of documentation#3709
Update copyright years and fix building of documentation#3709katzyn merged 5 commits intoh2database:masterfrom
Conversation
![sonatype-lift[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -1633,7 +1633,7 @@ private int getLivePageCount() { | |||
| * Put the page in the cache. | |||
| * @param page the page | |||
| */ | |||
| private void cachePage(Page<?,?> page) { | |||
| void cachePage(Page<?,?> page) { | |||
| if (cache != null) { | |||
| cache.put(page.getPos(), page, page.getMemory()); | |||
There was a problem hiding this comment.
THREAD_SAFETY_VIOLATION: Read/Write race. Non-private method FileStore.cachePage(...) indirectly reads with synchronization from this.cache.segments.[_]. Potentially races with unsynchronized write in method FileStore.rollbackTo(...).
Reporting because another access to the same memory occurs on a background thread, although this access may not.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -1680,7 +1680,7 @@ public void setCacheSize(int mb) { | |||
| } | |||
| } | |||
|
|
|||
| private void cacheToC(C chunk, long[] toc) { | |||
| void cacheToC(C chunk, long[] toc) { | |||
| chunksToC.put(chunk.version, toc, toc.length * 8L + Constants.MEMORY_ARRAY); | |||
There was a problem hiding this comment.
THREAD_SAFETY_VIOLATION: Read/Write race. Non-private method FileStore.cacheToC(...) indirectly reads with synchronization from this.chunksToC.segments.[_]. Potentially races with unsynchronized write in method FileStore.rollbackTo(...).
Reporting because another access to the same memory occurs on a background thread, although this access may not.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
1 participant
Some other compiler warnings are also fixed.